Changeset 1485

Timestamp:

07/10/08 18:14:52 (4 months ago)

Author:

rob

Message:

Turned off threaded loading of FundamentalMode? when loading stuff from the local filesystem
* speeds up file loading in most cases, possible loss of user interface responsiveness if happen to load over a shared drive that gets knocked out in the middle.

Location:

trunk/peppy

Files:

• buffers.py (modified) (1 diff)
• fundamental.py (modified) (1 diff)
• major.py (modified) (1 diff)

trunk/peppy/buffers.py

@@ -603 +603 @@
     
     def allowThreadedLoading(self):
-        return self.modecls.allow_threaded_loading
+        return self.modecls.preferThreadedLoading(self.user_url)
     
     def clone(self):

trunk/peppy/fundamental.py

@@ -198 +198 @@
         self.spell = None
 
+    @classmethod
+    def preferThreadedLoading(cls, url):
+        # For Fundamental mode and its descendants (unless overridden),
+        # threaded loading is disabled by default when loading from the local
+        # filesystem
+        if url.scheme == "file":
+            return False
+        return True
+
+
     def createWindowPostHook(self):
         """Apply settings for the STC"""

trunk/peppy/major.py

@@ -533 +533 @@
         """
         return None
+    
+    @classmethod
+    def preferThreadedLoading(cls, url):
+        """Returns preference for using threaded loading of the given URL
+        
+        Loading a file in a background thread is possible in peppy, but it
+        does cause a noticeable delay when loading a file from the local
+        filesystem.  This class method is provided to allow each major mode to
+        state its preference for threaded loading.
+        
+        Note that this preference will not be honored if the global setting for
+        threaded loading is disabled.
+        """
+        return True
+
 
     def save(self, url=None):